Fix image references and increase leniency of the pod anti affinity rule #5
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CloudStack CSI driver deployment configuration to fix image references and modify pod anti-affinity rules for better scheduling flexibility.
- Updates container image references from local names to fully qualified GitHub Container Registry URLs
- Changes pod anti-affinity from hard requirement to soft preference to allow more flexible scheduling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| deploy/k8s/node-daemonset.yaml | Updates container image to use fully qualified registry URL |
| deploy/k8s/controller-deployment.yaml | Updates container image and changes pod anti-affinity from required to preferred |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -59,7 +61,7 @@ spec: | |||
|
|
|||
| containers: | |||
| - name: cloudstack-csi-controller | |||
| image: cloudstack-csi-driver | |||
| image: ghcr.io/shapeblue/cloudstack-csi-driver:master | |||
There was a problem hiding this comment.
Using the 'master' tag for container images is not recommended for production deployments as it can lead to unpredictable behavior when the master branch is updated. Consider using a specific version tag or commit SHA for reproducible deployments.
| image: ghcr.io/shapeblue/cloudstack-csi-driver:master | |
| image: ghcr.io/shapeblue/cloudstack-csi-driver:v1.2.3 |
Copilot uses AI. Check for mistakes.
| @@ -36,7 +36,7 @@ spec: | |||
|
|
|||
| containers: | |||
| - name: cloudstack-csi-node | |||
| image: cloudstack-csi-driver | |||
| image: ghcr.io/shapeblue/cloudstack-csi-driver:master | |||
There was a problem hiding this comment.
Using the 'master' tag for container images is not recommended for production deployments as it can lead to unpredictable behavior when the master branch is updated. Consider using a specific version tag or commit SHA for reproducible deployments.
| image: ghcr.io/shapeblue/cloudstack-csi-driver:master | |
| image: ghcr.io/shapeblue/cloudstack-csi-driver:v1.2.3 |
Copilot uses AI. Check for mistakes.
Issue #, if available:
Description of changes:
Testing performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.